Review Request: Add and use alternative commant line program name

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103223/#review8433
-----------------------------------------------------------



kerfuffle/cliinterface.cpp
<http://git.reviewboard.kde.org/r/103223/#comment7158>

    This is being repeated many times over the file. Please overload runProcess() as suggested (or come up with another solution :) to avoid this copy'n'paste of the same code in many places.



kerfuffle/cliinterface.cpp
<http://git.reviewboard.kde.org/r/103223/#comment7157>

    This will always get the first item, even when there are many programs.



plugins/clizipplugin/cliplugin.cpp
<http://git.reviewboard.kde.org/r/103223/#comment7156>

    This change is unrelated.


- Raphael Kubo da Costa


On Nov. 23, 2011, 10:39 p.m., Michal Sciubidlo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103223/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2011, 10:39 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> Add and use alternative commant line program name.
> ListProgramAlternative, ExtractProgramAlternative, DeleteProgramAlternative, AddProgramAlternative can be set by CliInterface plugins if CliInterface can't find normal names it can use alternative ones. This patch is useful for 7z and 7za programs. Ark used 7z program but it's not allways installed. 7za can operate on 7z archives and is more common.
> 
> 
> This addresses bug 208864.
>     http://bugs.kde.org/show_bug.cgi?id=208864
> 
> 
> Diffs
> -----
> 
>   kerfuffle/cliinterface.h 2d4187c 
>   kerfuffle/cliinterface.cpp 90f77f2 
>   plugins/cli7zplugin/cliplugin.cpp 1742f91 
>   plugins/clilhaplugin/cliplugin.cpp c24b8ed 
>   plugins/clirarplugin/cliplugin.cpp 16179b8 
>   plugins/clizipplugin/cliplugin.cpp 23c77ef 
> 
> Diff: http://git.reviewboard.kde.org/r/103223/diff/diff
> 
> 
> Testing
> -------
> 
> Delete /usr/bin/7z file keep /usr/bin/7za. Ark still can work with 7z archives.
> 
> 
> Thanks,
> 
> Michal Sciubidlo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111123/9dec6ba0/attachment-0001.html>