Review Request: Fix crashes when closing ark during large archive loading. (1/4)

[Michal Sciubidlo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102903/
-----------------------------------------------------------

(Updated Nov. 16, 2011, 9:05 p.m.)


Review request for KDE Utils.


Changes
-------

Move from observers communication to signal-slot for asynchronous communication.


Summary (updated)
-----------------

Fix crashes when closing ark during large archive loading. (1/4)


Description
-------

When ark closes fastKill signal is send to any job that is in progress.
CliInterface process it, kills process and quits.
LibArchiveInterface processEvents and quits after fastKill signal.


This addresses bug 193908.
    http://bugs.kde.org/show_bug.cgi?id=193908


Diffs (updated)
-----

  kerfuffle/archiveinterface.h 86cc8e4 
  kerfuffle/archiveinterface.cpp 16b2455 
  kerfuffle/cliinterface.h 2d4187c 
  kerfuffle/cliinterface.cpp 90f77f2 
  kerfuffle/jobs.h 13c0494 
  kerfuffle/jobs.cpp 781920f 
  plugins/cli7zplugin/cliplugin.cpp 1742f91 
  plugins/clirarplugin/cliplugin.cpp 16179b8 
  plugins/clizipplugin/cliplugin.cpp 23c77ef 
  plugins/karchiveplugin/karchiveplugin.cpp 6543874 
  plugins/libarchive/libarchivehandler.h 9ec7541 
  plugins/libarchive/libarchivehandler.cpp ff711f4 
  plugins/libsinglefileplugin/singlefileplugin.h 67676e1 
  plugins/libsinglefileplugin/singlefileplugin.cpp e5aaf2a 

Diff: http://git.reviewboard.kde.org/r/102903/diff/diff


Testing
-------

opening tar.bz2, zip and closing ark during it. creating zip, tar.bz2.


Thanks,

Michal Sciubidlo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111116/3d15758a/attachment.html>