Review Request: Ark - "Add option to open-with, and also disable preview"

[peter velthuis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6580/
-----------------------------------------------------------

(Updated March 4, 2011, 4:07 p.m.)


Review request for kdeutils.


Summary (updated)
-------

-double click/enter: opens with default viewer
-'preview' button: opens the viewer like it does now.
-ctrl+w: 'open with' dialog shows to choose the application to open with. (it's
a KAction, but not added to a context menu or anything (yet)).

other:

QFile::remove calls removed and centralized in the destructor by deleting KTempDirs. 
It creates a folder per opened file, same behaviour as winrar. Why?

The problem is that you dont know when an external program closes (started through KRun) so we cant remove the file directly after the external program closes. So with one directory this scenario will happen: open file, (temp dir created and file extracted therre), user closes file, opens again .. and the message "File already exists" appears. Probably this is also the first reason why the current preview dialog was created=> we know when the user closes it.


This addresses bug 179066.
    https://bugs.kde.org/show_bug.cgi?id=179066


Diffs
-----

  /trunk/KDE/kdeutils/ark/part/arkviewer.cpp 1222951 
  /trunk/KDE/kdeutils/ark/part/part.h 1222951 
  /trunk/KDE/kdeutils/ark/part/part.cpp 1222951 

Diff: http://svn.reviewboard.kde.org/r/6580/diff


Testing
-------


Thanks,

peter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110304/64d07383/attachment.htm