Review Request: Fix bug 188857 "Ark follows settings in the Extraction dialog even when it was not used"

Scott Leggett sml at internode.on.net
Thu Jun 30 02:33:47 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6736/
-----------------------------------------------------------

Review request for kdeutils.


Summary
-------

Simple patch to display an error dialog and stop the ExtractJob when cancelling extraction of an archive in the 'overwrite query' dialog.

Fixes bug 188857 "Ark follows settings in the Extraction dialog even when it was not used"


This addresses bug 188857.
    https://bugs.kde.org/show_bug.cgi?id=188857


Diffs
-----

  /trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.cpp 1238821 
  /trunk/KDE/kdeutils/ark/kerfuffle/jobs.cpp 1238821 
  /trunk/KDE/kdeutils/ark/plugins/libarchive/libarchivehandler.cpp 1238821 
  /trunk/KDE/kdeutils/ark/plugins/libsinglefileplugin/singlefileplugin.cpp 1238821 

Diff: http://svn.reviewboard.kde.org/r/6736/diff


Testing
-------

Extracted, then cancelled files which use the three different plugin types (in use): cli, libarchive, libsinglefile.


Thanks,

Scott

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110630/ab9b5a08/attachment.htm 


More information about the Kde-utils-devel mailing list