Review Request: Fix for bug 252923 - show number of items in a directory

[Ghislain Mary]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6167/
-----------------------------------------------------------

(Updated 2011-01-02 16:35:37.227517)


Review request for kdeutils.


Changes
-------

Thanks for the review and sorry for the late reply. Here is an updated patch that should comply to your remarks.
I have done some performance checking with callgrind using several archives including some big ones (like the linux kernel sources). I have seen no performance penalty.


Summary
-------

This patch does what the bug report says but it tells how many folders and
files there are in a folder instead of just the number of items.
It also changes the info panel to have consistent information with the list
view.


This addresses bug 252923.
    https://bugs.kde.org/show_bug.cgi?id=252923


Diffs (updated)
-----

  /trunk/KDE/kdeutils/ark/part/archivemodel.h 1210887 
  /trunk/KDE/kdeutils/ark/part/archivemodel.cpp 1210887 
  /trunk/KDE/kdeutils/ark/part/infopanel.cpp 1210887 

Diff: http://svn.reviewboard.kde.org/r/6167/diff


Testing
-------

Tested with some archives contained in the kde source tree.


Thanks,

Ghislain

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-utils-devel/attachments/20110102/c5bf729f/attachment.htm