Review Request: Internal viewer: improve handling of unknown MIME types

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103110/
-----------------------------------------------------------

(Updated Dec. 29, 2011, 10:04 p.m.)


Review request for KDE Utils and Raphael Kubo da Costa.


Changes
-------

Only this single change implemented, TODO to save viewer window size will follow later in a separate review request.

Indented in kdelibs coding style, CamelCase'd variable names, used QLatin1String where necessary (now compiles against kdelibs 4.8)

Rewritten ArkViewer::view() with logic as suggested to have a single MIME type determination and only 2 places where the temporary file is removed.


Description
-------

Archives often contain files which contain and are viewable as plain text, but either resolve to a MIME type that does not have a suitable viewer KPart available, or the default MIME type application/octet-stream.  Trying to view such a file is simply rejected - and there is no "Open with" operation, so it is not easily possible to open the file in KWrite or another application.

This change gives the user the option, in this case, of viewing the file as plain text - whether this is will result in a sensible display for the file is their decision.  If they want to do that, ArkViewer::viewInInternalViewer() is forced to display the file as text/plain and not to try to detect the MIME type from the file name.

The size of the internal viewer window is also saved and restored, as per the TODO comment.

This change does introduce some new GUI strings, so it will not be able to be committed until after the KDE SC 4.8 release.


Diffs (updated)
-----

  part/arkviewer.h b810e17 
  part/arkviewer.cpp 9bfd651 

Diff: http://git.reviewboard.kde.org/r/103110/diff/diff


Testing
-------

Built ark with these changes, attempted to preview archive file contents for a variety of file types.  The extremely annoying "The internal viewer cannot preview this file" error message is now a thing of the past.


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111229/dfad3eec/attachment-0001.html>