Review Request: karchive plugin extract all fix

[Theofilos Intzoglou]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102960/#review9304
-----------------------------------------------------------



plugins/karchiveplugin/karchiveplugin.cpp
<http://git.reviewboard.kde.org/r/102960/#comment7686>

    Do you mean adding a QDir(filepath).exists() check or keeping created paths in memory?



plugins/karchiveplugin/karchiveplugin.cpp
<http://git.reviewboard.kde.org/r/102960/#comment7685>

    Normally, it shouldn't be possible to get to that return value. Sometimes I get a bit paranoid with the checks just to be sure that the program can handle every possible input. I guess I could replace the last 'else if' with an 'else'.


- Theofilos Intzoglou


On Nov. 24, 2011, 7:32 p.m., Theofilos Intzoglou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102960/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2011, 7:32 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> * If no item was selected from the archive, nothing was extracted! Now it extracts everything.
> * Check if an entry is a directory and append '/' if necessary
> 
> 
> Diffs
> -----
> 
>   plugins/karchiveplugin/karchiveplugin.h 1db6e07 
>   plugins/karchiveplugin/karchiveplugin.cpp 6543874 
> 
> Diff: http://git.reviewboard.kde.org/r/102960/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Theofilos Intzoglou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111227/7ab5915e/attachment.html>