Review Request: Added support for LZO archives

[Raphael Kubo da Costa]

> On Nov. 18, 2011, 1:57 p.m., Raphael Kubo da Costa wrote:
> > plugins/clilzoplugin/cliplugin.cpp, line 50
> > <http://git.reviewboard.kde.org/r/103100/diff/1/?file=40749#file40749line50>
> >
> >     lzop's man page lists some examples of how to extract single files. Do they not work?
> 
> Othmane Moustaouda wrote:
>     I could not find how to extract a single file, even on man page. Can you show me please if you found something?
>     
>     If is not possible to extract single files, maybe we can add a flag, something like SingleFilesExtractionSupported, then if false, CliInterface will extract the entire archive in /tmp, copying only specified files, it's also useful storing the path where the entire archive has been extracted in case the user want to extract/view another file from the same archive.
>     I thought it might be a solution, what do you think?

The "ADVANCED USAGE" in lzop's man page shows this:

  single file mode: individually (de)compress each file
    extract
    lzop -d a.c.lzo      -> restore a.c
    lzop -df a.c.lzo     -> restore a.c, overwrite if already exists
    lzop -d *.lzo

Isn't it possible to do this to handle single file extraction?


> On Nov. 18, 2011, 1:57 p.m., Raphael Kubo da Costa wrote:
> > plugins/clilzoplugin/kerfuffle_clilzo.desktop, line 64
> > <http://git.reviewboard.kde.org/r/103100/diff/1/?file=40750#file40750line64>
> >
> >     Can you rebase on top of master and set the mimetypes the way the other plugins are currently doing?
> 
> Othmane Moustaouda wrote:
>     LZO archives has two mimetypes, I was undecided about how to set them. After looking in clizipplugin/kerfuffle_clilzo.desktop I saw also there two mimetypes and I followed that way.
>     But if is not correct I can remove 'application/x-lzo-compressed;' because it's rarely used.
>

I think you can leave just "application/x-zlop". I couldn't find "x-lzo-compressed" in shared-mime-info's mime definitions (it's probably in /usr/share/mime/packages/freedesktop.org.xml in your system).


> On Nov. 18, 2011, 1:57 p.m., Raphael Kubo da Costa wrote:
> > plugins/clilzoplugin/cliplugin.cpp, line 47
> > <http://git.reviewboard.kde.org/r/103100/diff/1/?file=40749#file40749line47>
> >
> >     Wrong indentation. Plus, I'm not sure CliInterface can handle the case of only DeleteProgram not being defined. Have you tried to delete a file from an lzo archive in Ark?
> 
> Othmane Moustaouda wrote:
>     When I try to delete a file after the confirmation message:
>     "Deleting these files is not undoable. Are you sure you want to do this?"
>     
>     Then appears this error:
>     "Failed to locate program in PATH."
>     
>     Looking here http://api.kde.org/4.7-api/kdeutils-apidocs/ark/html/cliinterface_8cpp_source.html#l00324 CliInterface can manage omission of programs.
>     
>     Maybe I can add in CliInterface::deleteFiles a check, which control if DeleteProgram isn't defined, and displays a warning message saying that deletion is not supported?


- Raphael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103100/#review8294
-----------------------------------------------------------


On Nov. 26, 2011, 2:37 p.m., Othmane Moustaouda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103100/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2011, 2:37 p.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Description
> -------
> 
> Added support for LZO archives using lzop utility
> 
> 
> This addresses bug 211669.
>     http://bugs.kde.org/show_bug.cgi?id=211669
> 
> 
> Diffs
> -----
> 
>   plugins/clilzoplugin/cliplugin.h PRE-CREATION 
>   plugins/clilzoplugin/cliplugin.cpp PRE-CREATION 
>   plugins/clilzoplugin/kerfuffle_clilzo.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103100/diff/diff
> 
> 
> Testing
> -------
> 
> Listing and adding files to a new archive are working. There are some problems with deleting (lzop does not support it) and
> with adding files to an existing archive.
> 
> lzop does not fit perfectly with CLI interface, now I'm looking at how to change something to make it more elastic.
> 
> 
> Thanks,
> 
> Othmane Moustaouda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20111223/584203a6/attachment.html>