Review Request: Ark must recognize a disk full error when extracting files using an external tool (bug 206383)

[George Metaxas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5703/
-----------------------------------------------------------

(Updated 2010-11-01 07:47:37.347046)


Review request for kdeutils.


Changes
-------

Fixed minor bug that resulted in crash if no WriteErrorExpression was specified.


Summary
-------

Hello!
This patch fixes bug 206383 in ark, where ark cannot handle the situation of a disk becoming full, when using an external extracting utility (rar, unrar, unzip, etc). 


This addresses bug 206383.
    https://bugs.kde.org/show_bug.cgi?id=206383


Diffs (updated)
-----

  /trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.h 1191233 
  /trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.cpp 1191233 
  /trunk/KDE/kdeutils/ark/plugins/cli7zplugin/cliplugin.cpp 1191233 
  /trunk/KDE/kdeutils/ark/plugins/cliplugin/cliplugin.cpp 1191233 
  /trunk/KDE/kdeutils/ark/plugins/clirarplugin/cliplugin.cpp 1191233 
  /trunk/KDE/kdeutils/ark/plugins/clizipplugin/cliplugin.cpp 1191233 

Diff: http://svn.reviewboard.kde.org/r/5703/diff


Testing
-------

Tested the code using a file mounted through loop in a local directory, and proceeding to extract into it archives with the following types:
- A rar file
- A 7z file
- A zip file


Thanks,

George

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-utils-devel/attachments/20101101/f2391030/attachment.htm