Review Request: Command line option to sweeper (Bug 230568)

[eike.krumbacher at x-eike.de]

> On 2010-04-27 23:26:16, Raphael Kubo da Costa wrote:
> > If I understood the bug report correctly, the idea was to be able to launch Sweeper and make it clean everything with no GUI popping up at all, wasn't it?
> > 
> > This patch seems to do the automatic cleanup, yet the GUI is still shown before being closed automatically, no?
> 
> xeike wrote:
>     Indeed, the GUI is still shown for half a second.
>     With this patch, a user can use sweeper in KTimer and sweep every hour. Furthermore, in a graphical environment, one can use sweeper for scripts beeing executed in a graphical shell like terminal. "automatic" is adjustable and can act as "clear-all". 
>     
>
> 
> Raphael Kubo da Costa wrote:
>     Looking at the code, it seems rather simple to avoid the GUI altogether in this mode. Can you try to do that?

Are there any objections left?


- xeike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3820/#review5267
-----------------------------------------------------------


On 2010-05-04 17:17:56, xeike wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3820/
> -----------------------------------------------------------
> 
> (Updated 2010-05-04 17:17:56)
> 
> 
> Review request for kdeutils.
> 
> 
> Summary
> -------
> 
> Hi!
> 
> The patch adds a command line opton to sweeper. Using this command line option, sweeper starts, sweeps and finishes without user interaction.
> Instad of the suggested "--clear-all", I just use "automatic", because the user can edit what to clear during an interactive session.
> 
> 
> This addresses bug 230568.
>     https://bugs.kde.org/show_bug.cgi?id=230568
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeutils/sweeper/main.cpp 1122773 
>   /trunk/KDE/kdeutils/sweeper/sweeper.h 1122773 
>   /trunk/KDE/kdeutils/sweeper/sweeper.cpp 1122773 
> 
> Diff: http://reviewboard.kde.org/r/3820/diff
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> xeike
> 
>