Review Request: Regrouping of buttons, Inv to Shift

[eike.krumbacher at x-eike.de]

> On 2010-05-12 19:41:00, Raphael Kubo da Costa wrote:
> > I agree with the Inv->Shift conversion, however I, as a user, think that the sqrt button is more frequently used than the x^3 button, and it feels weird to have it "far" from the x^2. Is this last part really needed?

We have ln/exp(x), sin(x)/asin(x) and so on, so it feels like cleaning up doing this. Some of the calculators do it like this, but other have seperate buttons for sqrt(x) and x^2 next to each other. There is no such thing as a common case, as far as I have seen on several science calc pages. We could flip a coin :-) or ask the list.


- xeike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3957/#review5637
-----------------------------------------------------------


On 2010-05-12 14:21:19, xeike wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3957/
> -----------------------------------------------------------
> 
> (Updated 2010-05-12 14:21:19)
> 
> 
> Review request for kdeutils.
> 
> 
> Summary
> -------
> 
> This diff is one more step towards 107393. 
> 
> Currently, all roots are grouped together and the powers are grouped together, selectable by an "Inv" button. 
> 
> This patch groups x^2 together with sqrt(x) on the same button and x^3 with 3rd root(x). The button to toggle between the alternatives is now "Shift", as I have seen on the casio websites for different languages. "Inv" claims to be an "inverse" mode and we know, that some of the inverse functions are not really inverse to the second function they show. So this is more a "second button function". 
> 
> * Visible Changes are:
> - Inv button to Shift button, switched root button to x^3 button and regrouping of Shift functions
> - Displays and statusbar update. 
> - Button to toggle "Shift" is CTRL+2 for second function
> 
> * Source Changes are:
> - changed enum names and variables from inv to shift
> 
> * Bugs:
> - There was and is something wrong with the status bar as the window gets bigger or smaller. More on the mailing list.
> - 107393 has more suggestions than this and someone has done some work on it. But we cannot close this bug.
> 
> 
> This addresses bug 107393.
>     https://bugs.kde.org/show_bug.cgi?id=107393
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeutils/kcalc/kcalc.h 1125843 
>   trunk/KDE/kdeutils/kcalc/kcalc.cpp 1125843 
>   trunk/KDE/kdeutils/kcalc/kcalc.ui 1125843 
>   trunk/KDE/kdeutils/kcalc/kcalc_button.h 1125843 
>   trunk/KDE/kdeutils/kcalc/kcalc_button.cpp 1125843 
>   trunk/KDE/kdeutils/kcalc/kcalc_const_button.cpp 1125843 
>   trunk/KDE/kdeutils/kcalc/kcalcdisplay.cpp 1125843 
> 
> Diff: http://reviewboard.kde.org/r/3957/diff
> 
> 
> Testing
> -------
> 
> tried out x^2, x^3, sqrt(x), 3rd root (x). 
> 
> 
> Thanks,
> 
> xeike
> 
>