Review Request: Regrouping of buttons, Inv to Shift

eike.krumbacher at x-eike.de eike.krumbacher at x-eike.de
Wed May 12 16:21:19 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3957/
-----------------------------------------------------------

Review request for kdeutils.


Summary
-------

This diff is one more step towards 107393. 

Currently, all roots are grouped together and the powers are grouped together, selectable by an "Inv" button. 

This patch groups x^2 together with sqrt(x) on the same button and x^3 with 3rd root(x). The button to toggle between the alternatives is now "Shift", as I have seen on the casio websites for different languages. "Inv" claims to be an "inverse" mode and we know, that some of the inverse functions are not really inverse to the second function they show. So this is more a "second button function". 

* Visible Changes are:
- Inv button to Shift button, switched root button to x^3 button and regrouping of Shift functions
- Displays and statusbar update. 
- Button to toggle "Shift" is CTRL+2 for second function

* Source Changes are:
- changed enum names and variables from inv to shift

* Bugs:
- There was and is something wrong with the status bar as the window gets bigger or smaller. More on the mailing list.
- 107393 has more suggestions than this and someone has done some work on it. But we cannot close this bug.


This addresses bug 107393.
    https://bugs.kde.org/show_bug.cgi?id=107393


Diffs
-----

  trunk/KDE/kdeutils/kcalc/kcalc.h 1125843 
  trunk/KDE/kdeutils/kcalc/kcalc.cpp 1125843 
  trunk/KDE/kdeutils/kcalc/kcalc.ui 1125843 
  trunk/KDE/kdeutils/kcalc/kcalc_button.h 1125843 
  trunk/KDE/kdeutils/kcalc/kcalc_button.cpp 1125843 
  trunk/KDE/kdeutils/kcalc/kcalc_const_button.cpp 1125843 
  trunk/KDE/kdeutils/kcalc/kcalcdisplay.cpp 1125843 

Diff: http://reviewboard.kde.org/r/3957/diff


Testing
-------

tried out x^2, x^3, sqrt(x), 3rd root (x). 


Thanks,

xeike



More information about the Kde-utils-devel mailing list