Review Request: Coding Style to KCalc

[eike.krumbacher at x-eike.de]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3901/
-----------------------------------------------------------

(Updated 2010-05-09 14:32:10.981977)


Review request for kdeutils.


Changes
-------

Tha changed diff is now without the "-D" option. So no spaces arround braces and its the least intrusive style change. But please note, this is a long diff as many lines use tab and spaces mixed together. 


Summary
-------

The attached patch is just a coding style update to kcalc.

I used the astyle program as described on
http://techbase.kde.org/Policies/Kdelibs_Coding_Style
and added the -D option to add an extra space character after opening ( and before closing ). 

Eike


Diffs (updated)
-----

  /trunk/KDE/kdeutils/kcalc/kcalc.h 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalc.cpp 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalc_bitset.h 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalc_bitset.cpp 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalc_button.h 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalc_button.cpp 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalc_const_button.h 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalc_const_button.cpp 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalc_const_menu.h 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalc_const_menu.cpp 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalc_core.h 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalc_core.cpp 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalcdisplay.h 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalcdisplay.cpp 1124578 
  /trunk/KDE/kdeutils/kcalc/kcalctype.h 1124578 
  /trunk/KDE/kdeutils/kcalc/knumber/knumber.h 1124578 
  /trunk/KDE/kdeutils/kcalc/knumber/knumber.cpp 1124578 
  /trunk/KDE/kdeutils/kcalc/knumber/knumber_priv.h 1124578 
  /trunk/KDE/kdeutils/kcalc/knumber/knumber_priv.cpp 1124578 
  /trunk/KDE/kdeutils/kcalc/knumber/tests/knumbertest.cpp 1124578 
  /trunk/KDE/kdeutils/kcalc/stats.h 1124578 
  /trunk/KDE/kdeutils/kcalc/stats.cpp 1124578 

Diff: http://reviewboard.kde.org/r/3901/diff


Testing
-------

The program compiles (cmake) and runs. Some calculations. 


Thanks,

xeike