Review Request: Coding Style to KCalc

[alex.richardson at gmx.de]

> On 2010-05-06 21:38:41, arichardson wrote:
> > I disagree here. The coding style is consistent and does not contain spaces around the arguments in method calls/declarations. I'd say leave it as it is. However I do think it is a good idea to remove trailing spaces in empty lines.
> 
> xeike wrote:
>     Please have a look at kcalc.h. It mixes up tabs and spaces for indentation. Sometimes, it uses
>     func(parameter); and sometimes func( parameter ); Note the space. 
>     
>     In kcalc.cpp, you find setStatusText(foo); and setEnable (foo); with a space before "(". 
>     
>     Same goes for "{". Same line as if and next line, mixed in kcalc.cpp. 
>     
>     
>     
>

Sorry, didn't see that. I'd say definetely keep it consistent, I don't mind which way (although personally I prefer the style without spaces in function declarations and invocations) and I doubt I have anything to say in that matter since I'm not really involved in KCalc :)


- arichardson


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3901/#review5480
-----------------------------------------------------------


On 2010-05-06 21:22:51, xeike wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3901/
> -----------------------------------------------------------
> 
> (Updated 2010-05-06 21:22:51)
> 
> 
> Review request for kdeutils.
> 
> 
> Summary
> -------
> 
> The attached patch is just a coding style update to kcalc.
> 
> I used the astyle program as described on
> http://techbase.kde.org/Policies/Kdelibs_Coding_Style
> and added the -D option to add an extra space character after opening ( and before closing ). 
> 
> Eike
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeutils/kcalc/kcalc.h 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalc.cpp 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalc_bitset.h 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalc_bitset.cpp 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalc_button.h 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalc_button.cpp 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalc_const_button.h 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalc_const_button.cpp 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalc_const_menu.h 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalc_const_menu.cpp 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalc_core.h 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalc_core.cpp 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalcdisplay.h 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalcdisplay.cpp 1123755 
>   /trunk/KDE/kdeutils/kcalc/kcalctype.h 1123755 
>   /trunk/KDE/kdeutils/kcalc/knumber/knumber.h 1123755 
>   /trunk/KDE/kdeutils/kcalc/knumber/knumber.cpp 1123755 
>   /trunk/KDE/kdeutils/kcalc/knumber/knumber_priv.h 1123755 
>   /trunk/KDE/kdeutils/kcalc/knumber/knumber_priv.cpp 1123755 
>   /trunk/KDE/kdeutils/kcalc/knumber/tests/knumbertest.cpp 1123755 
>   /trunk/KDE/kdeutils/kcalc/stats.h 1123755 
>   /trunk/KDE/kdeutils/kcalc/stats.cpp 1123755 
> 
> Diff: http://reviewboard.kde.org/r/3901/diff
> 
> 
> Testing
> -------
> 
> The program compiles (cmake) and runs. Some calculations. 
> 
> 
> Thanks,
> 
> xeike
> 
>