Review Request: Coding Style to KCalc

eike.krumbacher at x-eike.de eike.krumbacher at x-eike.de
Thu May 6 23:22:52 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3901/
-----------------------------------------------------------

Review request for kdeutils.


Summary
-------

The attached patch is just a coding style update to kcalc.

I used the astyle program as described on
http://techbase.kde.org/Policies/Kdelibs_Coding_Style
and added the -D option to add an extra space character after opening ( and before closing ). 

Eike


Diffs
-----

  /trunk/KDE/kdeutils/kcalc/kcalc.h 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalc.cpp 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalc_bitset.h 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalc_bitset.cpp 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalc_button.h 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalc_button.cpp 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalc_const_button.h 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalc_const_button.cpp 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalc_const_menu.h 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalc_const_menu.cpp 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalc_core.h 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalc_core.cpp 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalcdisplay.h 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalcdisplay.cpp 1123755 
  /trunk/KDE/kdeutils/kcalc/kcalctype.h 1123755 
  /trunk/KDE/kdeutils/kcalc/knumber/knumber.h 1123755 
  /trunk/KDE/kdeutils/kcalc/knumber/knumber.cpp 1123755 
  /trunk/KDE/kdeutils/kcalc/knumber/knumber_priv.h 1123755 
  /trunk/KDE/kdeutils/kcalc/knumber/knumber_priv.cpp 1123755 
  /trunk/KDE/kdeutils/kcalc/knumber/tests/knumbertest.cpp 1123755 
  /trunk/KDE/kdeutils/kcalc/stats.h 1123755 
  /trunk/KDE/kdeutils/kcalc/stats.cpp 1123755 

Diff: http://reviewboard.kde.org/r/3901/diff


Testing
-------

The program compiles (cmake) and runs. Some calculations. 


Thanks,

xeike



More information about the Kde-utils-devel mailing list