Review Request: Command line option to sweeper (Bug 230568)

eike.krumbacher at x-eike.de eike.krumbacher at x-eike.de
Tue May 4 19:17:56 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3820/
-----------------------------------------------------------

(Updated 2010-05-04 17:17:56.791024)


Review request for kdeutils.


Changes
-------

I did not find out, how to run sweeper in a shell without a GUI arround. But I moved all show() operations into if(not automatic). See main.cpp in the diff for details. 


Summary
-------

Hi!

The patch adds a command line opton to sweeper. Using this command line option, sweeper starts, sweeps and finishes without user interaction.
Instad of the suggested "--clear-all", I just use "automatic", because the user can edit what to clear during an interactive session.


This addresses bug 230568.
    https://bugs.kde.org/show_bug.cgi?id=230568


Diffs (updated)
-----

  /trunk/KDE/kdeutils/sweeper/main.cpp 1122773 
  /trunk/KDE/kdeutils/sweeper/sweeper.h 1122773 
  /trunk/KDE/kdeutils/sweeper/sweeper.cpp 1122773 

Diff: http://reviewboard.kde.org/r/3820/diff


Testing
-------

yes


Thanks,

xeike



More information about the Kde-utils-devel mailing list