Review Request: First patch for dar support in ark

[robin at binro.org]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6113/
-----------------------------------------------------------

(Updated 2010-12-14 15:19:02.896447)


Review request for kdeutils and Raphael Kubo da Costa.


Summary (updated)
-------

Add ark plugin for dar (Disk Archiver http://dar.linux.free.fr/).

Your suggestion to make isReadOnly() return false did not seem to make any difference. I think the simplest way is check if the AddProgram and DeleteProgram parameters are actually set and issue an error message if not. This check probably should have been done anyway! This way plugins can indicate which operations they support.


Diffs
-----

  /trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.h 1206114 
  /trunk/KDE/kdeutils/ark/kerfuffle/cliinterface.cpp 1206114 
  /trunk/KDE/kdeutils/ark/plugins/CMakeLists.txt 1206114 
  /trunk/KDE/kdeutils/ark/plugins/clidarplugin/CMakeLists.txt PRE-CREATION 
  /trunk/KDE/kdeutils/ark/plugins/clidarplugin/cliplugin.h PRE-CREATION 
  /trunk/KDE/kdeutils/ark/plugins/clidarplugin/cliplugin.cpp PRE-CREATION 
  /trunk/KDE/kdeutils/ark/plugins/clidarplugin/kerfuffle_clidar.desktop PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/6113/diff


Testing
-------

Listing archives and extracting files works fine locally using KDE 4.5.4.


Screenshots
-----------

Ark showing dar archive
  http://svn.reviewboard.kde.org/r/6113/s/579/


Thanks,

binro

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-utils-devel/attachments/20101214/2c970284/attachment.htm