Review Request: Command line option to sweeper (Bug 230568)

Raphael Kubo da Costa kubito at gmail.com
Wed Apr 28 01:26:11 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3820/#review5267
-----------------------------------------------------------


If I understood the bug report correctly, the idea was to be able to launch Sweeper and make it clean everything with no GUI popping up at all, wasn't it?

This patch seems to do the automatic cleanup, yet the GUI is still shown before being closed automatically, no?

- Raphael


On 2010-04-27 16:45:30, xeike wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3820/
> -----------------------------------------------------------
> 
> (Updated 2010-04-27 16:45:30)
> 
> 
> Review request for kdeutils.
> 
> 
> Summary
> -------
> 
> Hi!
> 
> The patch adds a command line opton to sweeper. Using this command line option, sweeper starts, sweeps and finishes without user interaction.
> Instad of the suggested "--clear-all", I just use "automatic", because the user can edit what to clear during an interactive session.
> 
> 
> This addresses bug 230568.
>     https://bugs.kde.org/show_bug.cgi?id=230568
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeutils/sweeper/main.cpp 1119653 
>   /trunk/KDE/kdeutils/sweeper/sweeper.h 1119653 
>   /trunk/KDE/kdeutils/sweeper/sweeper.cpp 1119653 
> 
> Diff: http://reviewboard.kde.org/r/3820/diff
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> xeike
> 
>



More information about the Kde-utils-devel mailing list