kcalc suggestions

[Eike Krumbacher]

Hi!


Raphael Kubo da Costa schrieb:
> The patch looks almost OK to me. My remaining concerns are "language"-related. 
> Last but not least, do you know if there are bug reports that will be touched 
> by this commit (either some report that is going to be fixed, or some report 
> that will be reopened)?
>   
Not with this patch, but there are some, which can be closed after modes 
are fully introduced.

* *Bug 230141* <https://bugs.kde.org/show_bug.cgi?id=230141> - in kcalc 
bit edit is inactive when logic buttons are hidden

_S_ummary:
	in kcalc bit edit is inactive when logic buttons are hidden

(you cannot use bit edit without logic buttons after we have the mode 
feature)

** Bug 21190* <https://bugs.kde.org/show_bug.cgi?id=21190> - calculating 
with hours and minutes
(just a mode)

_S_ummary:
	calculating with hours and minutes


** Bug 114930* <https://bugs.kde.org/show_bug.cgi?id=114930> - Introduce 
Modes/Profiles, add features for schools

** Bug 229539* <https://bugs.kde.org/show_bug.cgi?id=229539> - Option to 
use Kcalc as stripped-down simple calculator with no scientific buttons
(This is our simple mode, but I have to work on it)



_S_ummary:
	Introduce Modes/Profiles, add features for schools


> Were we to follow the API style guidelines, it'd be better to be more explicit 
> and avoid abbreviations. In this case, CalcMode would become CalculatorMode.
>
>   

It's now CalculatorMode, and the mode is named "simple" :-)

> Heh, why Numeral? :)
>
>   

In this mode, we use different numeral systems, like bin and hex. I have 
looked up in
http://en.wikipedia.org/wiki/Numeral_system :-)



> +       actionModeEasy->setText( i18n("Eas&y Mode") );
>
> I don't remember if you need to set the accelerator character manually. If so, 
> don't you also need to set it for the other modes as well?
>   
I removed this accelerator character.



Eike

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kcalc_modes_ek3.diff
Type: text/x-patch
Size: 12051 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-utils-devel/attachments/20100426/ba277c86/attachment.diff