Patch for 224859

Raphael Kubo da Costa kubito at gmail.com
Mon Apr 12 19:51:16 CEST 2010


On Monday 12 April 2010 14:06:27 Eike Krumbacher wrote:
> Raphael Kubo da Costa schrieb:
> > On Wednesday 07 April 2010 17:04:37 Raphael Kubo da Costa wrote:
> >> Hey Eike,
> >> 
> >> I was thinking about this again, and I think it's better to use
> >> KStandardAction::quit instead of creating a KAction and assign
> > 
> > Ctrl+Q to it
> > 
> >> -- if the user changes the standard shortcut to quit applications,
> > 
> > KTimer
> > 
> >> should follow accordingly.
> >> 
> >> This way, I suggest using KAction *exit = KStandardAction::quit(this,
> >> SLOT(exit()), this); for example.
> 
> Oh yes, I was a bit busy because of my wedding (my last name changed)
> but I'm back.

Right, I thought you had given up on my reviews :)

Committed as r1114075 and backported as r1114077.

Thanks!


More information about the Kde-utils-devel mailing list