Patch for 224859

Raphael Kubo da Costa kubito at gmail.com
Wed Apr 7 22:04:37 CEST 2010


On Wednesday 07 April 2010 06:39:50 Eike Lange wrote:
> Hi Raphael
> 
> Raphael Kubo da Costa schrieb:
> > I'd rather use KAction instead of QAction, and add the related #includes.
> > Other than that, the patch looks fine.
> 
> Done and attached.
> 
> > Do you have an svn account?
> 
> No,not at the moment. Maybe, I ask for one, if I have some more
> experiences.
> 
> Eike

Hey Eike,

I was thinking about this again, and I think it's better to use 
KStandardAction::quit instead of creating a KAction and assign Ctrl+Q to it -- 
if the user changes the standard shortcut to quit applications, KTimer should 
follow accordingly.

This way, I suggest using KAction *exit = KStandardAction::quit(this, 
SLOT(exit()), this); for example.

Cheers,
Raphael


More information about the Kde-utils-devel mailing list