Review Request 127005: Port to QWebEngine

[Martin Klapetek]

> On Feb. 13, 2017, 12:18 a.m., Aleix Pol Gonzalez wrote:
> > +1 LGTM.
> > 
> > Yes, QtWebEngine is an acceptable dependency.
> 
> Niels Ole Salscheider wrote:
>     That's good to hear.
>     
>     Does anybody feel like giving me a "Ship it" or is there something left that I should fix?
>     I've been using this for months and I didn't notice any problems...

I'll have the packagers sign off this. If nobody objects in a week, consider this a ship it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127005/#review102519
-----------------------------------------------------------


On Feb. 11, 2017, 7:32 p.m., Niels Ole Salscheider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127005/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2017, 7:32 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> This ports the message viewer from QWebKit to QWebEngine.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 86aa80a 
>   adiumxtra-protocol-handler/CMakeLists.txt f78a62f 
>   app/CMakeLists.txt 9a90cec 
>   config/appearance/CMakeLists.txt dfb5d04 
>   config/appearance/appearance-config-tab.cpp f2f298b 
>   lib/CMakeLists.txt 5294521 
>   lib/adium-theme-view.h 5a0c2e6 
>   lib/adium-theme-view.cpp d1c93f4 
>   lib/chat-search-bar.h c8c5118 
>   lib/chat-search-bar.cpp 484975a 
>   lib/chat-widget.h 588407c 
>   lib/chat-widget.cpp fdc9c1e 
>   logviewer/CMakeLists.txt c36157c 
>   logviewer/log-viewer.cpp b1dad26 
>   logviewer/message-view.h ec592c7 
>   logviewer/message-view.cpp 1b3bbe4 
> 
> Diff: https://git.reviewboard.kde.org/r/127005/diff/
> 
> 
> Testing
> -------
> 
> - Builds
> - Chats with the text UI work
> - Links work
> - The log viewer works
> 
> 
> Thanks,
> 
> Niels Ole Salscheider
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20170304/30f270f2/attachment.html>