Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

James Smith smithjd15 at gmail.com
Sat Jan 28 23:54:52 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123504/
-----------------------------------------------------------

(Updated Jan. 28, 2017, 4:54 p.m.)


Review request for Telepathy and Martin Klapetek.


Changes
-------

Rebase and port to setPlugin().
1) setActivePlayerMessage() message setting simplification.
2) sortPlayerReply() simplification.
3) statusMessage() condensing.
4) Move playState() into sortPlayerReply().
5) emptyInfoSeparator hidden config option change to nowPlayingSpacer.
6) Copyright, comment and other small changes.


Repository: ktp-kded-module


Description
-------

New features:
-Much improved multiple player handling; a number of service availability bugs were fixed.
-Ignore tracks with inadequate metadata
-Separator for empty metadata info fields with (currently) hidden config


Diffs (updated)
-----

  telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
  telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 

Diff: https://git.reviewboard.kde.org/r/123504/diff/


Testing
-------

Compile, run.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20170128/8dc26155/attachment-0001.html>


More information about the KDE-Telepathy mailing list