Review Request 123487: ktp-contact-list status handler multiple account presence changes

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123487/
-----------------------------------------------------------

(Updated Jan. 27, 2017, 9:13 p.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

GlobalPresenceChooser:
1) New public setPresence() method and accountsOnline() bool provide GlobalPresence::setPresence() method and accounts online info for MainWidget. Previously, 2 different GlobalPresence objects were created. Internally replace GlobalPresence::setPresence() with setPresence().
2) More new-style signals and slots.
3) More ranged for loops.
4) Copyright changes and other cleanups.

AdvancedPresenceDialog:
1) Fix the dialog closing on enter keypress with the cursor focus in a combo box.


Bugs: 181748
    http://bugs.kde.org/show_bug.cgi?id=181748


Repository: ktp-contact-list


Description (updated)
-------

New classes:
AdvancedPresenceDialog, a dialog for advanced presence setting.

New methods:
-GlobalPresenceChooser::setPresence(KTp::Presence).

New properties:
-GlobalPresenceChooser::onlineAccounts().

New features:
-GlobalPresenceChooser uses StatusHandlerPresence to enable PluginQueue plugins, and quick status message changes if the status handler is available.
-Extend GlobalPresence::setPresence() and bool onlineAccounts() to MainWindow from GlobalPresenceChooser.


Diffs (updated)
-----

  CMakeLists.txt 17dd7b88c8d2e07bc7a6189fddf26eb3cc94db75 
  dialogs/advanced-presence-dialog.h PRE-CREATION 
  dialogs/advanced-presence-dialog.cpp PRE-CREATION 
  global-presence-chooser.h f07b8823077e1558047ce019f13e619ca6b432c3 
  global-presence-chooser.cpp 323217c82a4ba9f139f38a26734e152915147c25 
  main-widget.h 43334ef8442217154f0df198ce601c9b996914d9 
  main-widget.cpp 4b4f7004cf6bc5f0db166ce9e13f056508f68484 

Diff: https://git.reviewboard.kde.org/r/123487/diff/


Testing
-------

Compile, run.


File Attachments
----------------

Advanced Presence Setting option
  https://git.reviewboard.kde.org/media/uploaded/files/2016/02/06/0f7aa5e8-c3a5-4d2f-9549-32531cddd009__advancedpresencedialogoption.png
Advanced Presence Setting dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2016/02/17/b9c5741d-89f6-48f7-887c-68ebffb737c4__advancedpresencedialog.png
Advanced Presence Setting dialog editing status message
  https://git.reviewboard.kde.org/media/uploaded/files/2016/02/17/6b368cf1-426e-41da-910e-a732463c42c1__advancedpresencedialogstatusmessage.png


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20170128/2761db6b/attachment.html>