Review Request 123485: ktp-kded-module status handler multiple account presence

Mon Feb 27 04:48:43 UTC 2017

> On Feb. 22, 2017, 8:14 p.m., Martin Klapetek wrote:
> > As I have explained many many times, I will *not* accept any patch including/extending plugin queue. The whole plugin queue has to go together with the mpris2 thing.
> > 
> > I'm sorry but if you don't intend to work towards that and/or work as a team towards common goal of this project, I will have to ask you to just discard this altogether.
> 
> James Smith wrote:
>     I'd prefer to keep it open for now. If someone *really* has an issue with it still being open, then perhaps we can get some additional comments or 'ship it!'s.
>     
>     My current understanding is that you don't like the status message capability, and autoaway capability.
>     
>     The presence queue logic has to stay, to replace existing (broken) functionality in GlobalPresence. Since the status message counterpart of this functionality is also useful for setting a global status message independent of per-account presences, there are no savings to eliminating the mpris plugin, just loss of (already existing) functionality. The presence infrastructure is a) already shared with status message plugins, and b) required for juggling multiple presence possibilities, and c) a plugin is a logical way to replace per-app save / restore presence. There are no savings this way in removing AutoAway functionality either.
>     
>     I'm not completely against removing the AutoAway plugin, and I'd personally like to keep the mpris plugin, and the plugin queue itself is useful.

> My current understanding is that you don't like the status message capability, and autoaway capability.

Your understanding is wrong. I want simple autoaway and lock screen integration, that's all. There is no queue needed for this nor any incredible complexity as everything would become mutually exclusive - you either have autoaway xor lock screen status xor your own status. It's that simple. If GlobalPresence is broken, then it needs fixing but not by introducing thousands new lines of code. If it cannot be fixed, it should be rewritten from scratch while being as simple as possible.

This whole patch group is a no-go and as the acting project maintainer I will not give it any approval now or next year.

If you really want this in, I suggest you fork the KDE Telepathy project and start shipping your fork.

- Martin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123485/#review102574
-----------------------------------------------------------

On Feb. 22, 2017, 7:52 p.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123485/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2017, 7:52 p.m.)
> 
> 
> Review request for Telepathy, Dominik Cermak, David Edmundson, Lucas Betschart, and Martin Klapetek.
> 
> 
> Bugs: 293443, 297924, 334542, 337881, 340201, and 340781
>     http://bugs.kde.org/show_bug.cgi?id=293443
>     http://bugs.kde.org/show_bug.cgi?id=297924
>     http://bugs.kde.org/show_bug.cgi?id=334542
>     http://bugs.kde.org/show_bug.cgi?id=337881
>     http://bugs.kde.org/show_bug.cgi?id=340201
>     http://bugs.kde.org/show_bug.cgi?id=340781
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> New classes:
> -AccountStatusHelper, a multiple-account-presence QDBusAbstractInterface replacement for AutoConnect.
> -PluginQueue, a QDBusAbstractInterface for presence and status message plugins.
> -Presence / Status Message Inserter classes, for queuing presences and status messages.
> 
> New properties:
> -TelepathyKDEDModulePlugin: KTp::PluginQueue pluginState().
> 
> New methods:
> -TelepathyKDEDModulePlugin: virtual pluginInit(bool), method setPlugin(State), method setPlugin(KTp::Presence), method setPlugin(QString), method configureEnabled(bool).
> 
> New features:
> -Newly enabled and online account presence changes to account requested presence, or plugin presence depending on autoconnect property, and plugin queue state.
> -Offline global presence will override per-account presences temporarily.
> -PluginQueue globs presence change events.
> -StatusHandler dynamically disables and enables plugin queues if there are online accounts.
> -StatusHandler and TelepathyKDEDModulePlugin no longer require GlobalPresence.
> 
> Various other cleanups, documentation, and improvements.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4dbaab64189d819a27e5b36fd10098f0fac3dbc6 
>   account-status-helper.h PRE-CREATION 
>   account-status-helper.cpp PRE-CREATION 
>   autoaway.h 5e2a56100b56e6d21bc649f9032c8bece9031452 
>   autoaway.cpp 4881c71afab2be2468c3c883523d2844865e6247 
>   autoconnect.h 0f3ab137cf67cce9c7467144a45d1706ec9cc007 
>   autoconnect.cpp 99512b265e0e6ae34f83263ffa6337741db652ea 
>   config/telepathy-kded-config.cpp 88220645c2e119dc7879cdae065cbbf06aa13329 
>   config/telepathy-kded-config.ui 2b80dfa34381af2e9206384a31c025f9b914854a 
>   org.kde.Telepathy.AccountStatusHelper.xml PRE-CREATION 
>   org.kde.Telepathy.PluginQueue.xml PRE-CREATION 
>   screensaveraway.h 92344e891ccde16d53771c3e279d845f4d800b2d 
>   screensaveraway.cpp f226564a5bf7b396965b5ae21f81d93b7edc3ef8 
>   status-handler-plugin-queue.h PRE-CREATION 
>   status-handler-plugin-queue.cpp PRE-CREATION 
>   status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff 
>   status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc 
>   telepathy-kded-module-plugin.h 4c161696a706e82059a7eb314773c3644fe26bd7 
>   telepathy-kded-module-plugin.cpp daf73c66947bc946097de7a8e8a1518555131145 
>   telepathy-module.h 17ef4cef27b90cbced6c66846ed82cb5c36fb532 
>   telepathy-module.cpp b74053bc1817d773a4fe37769e42f4013ced5425 
>   telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
>   telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 
>   telepathy-status-inserter.h PRE-CREATION 
>   telepathy-status-inserter.cpp PRE-CREATION 
>   tests/CMakeLists.txt 7ec77495417a6790060ea5ea7126c46399dff755 
> 
> Diff: https://git.reviewboard.kde.org/r/123485/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20170227/70cded7a/attachment-0001.html>