Review Request 130222: Fix the go offline dialog

[James Smith]

> On Aug. 11, 2017, 2:39 p.m., David Edmundson wrote:
> > main-widget.cpp, line 302
> > <https://git.reviewboard.kde.org/r/130222/diff/1/?file=498730#file498730line302>
> >
> >     why check for a key and not the value of they key?
> >     
> >     your other patch does not do removeEntry, so this won't work.

The dialog is only shown if there is no prior configuration. It's also possible to replicate or reverse any possible dialog configuration with the kcm control.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130222/#review103591
-----------------------------------------------------------


On Aug. 10, 2017, 9:24 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130222/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2017, 9:24 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Make the dialog appear if there is no config found for other presence controls.
> 
> 
> Diffs
> -----
> 
>   main-widget.h 43334ef8442217154f0df198ce601c9b996914d9 
>   main-widget.cpp 4b4f7004cf6bc5f0db166ce9e13f056508f68484 
> 
> Diff: https://git.reviewboard.kde.org/r/130222/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20170811/30a484e5/attachment.html>