Review Request 129069: [Quick Chat] Remove unused popupSide property

Aleix Pol Gonzalez aleixpol at kde.org
Thu Sep 29 10:31:41 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129069/#review99657
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Sept. 29, 2016, 10:20 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129069/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2016, 10:20 a.m.)
> 
> 
> Review request for Telepathy and Aleix Pol Gonzalez.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> This property is unused and PlasmaCore.Dialog location and visualParent already take care of this.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml a089fbc 
>   chat/org.kde.ktp-chat/contents/ui/FullChatList.qml 258c1cf 
> 
> Diff: https://git.reviewboard.kde.org/r/129069/diff/
> 
> 
> Testing
> -------
> 
> Popup location still sensible in all four panel locations
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160929/49f75329/attachment.html>


More information about the KDE-Telepathy mailing list