Review Request 129017: [ktp-auth-handler] Ported from deprecated KAboutData::setProgramIconName()

Aleix Pol Gonzalez aleixpol at kde.org
Sun Sep 25 23:16:31 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129017/#review99520
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Sept. 25, 2016, 7:35 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129017/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2016, 7:35 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-auth-handler
> 
> 
> Description
> -------
> 
> KAboutData::setProgramIconName() replaced by QApplication::setWindowIcon(QIcon::fromTheme()), as it is recommended at the KAboutData header file
> 
> 
> Diffs
> -----
> 
>   main.cpp 2243100 
> 
> Diff: https://git.reviewboard.kde.org/r/129017/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160925/1757d9b3/attachment.html>


More information about the KDE-Telepathy mailing list