Review Request 129016: [ktp-auth-handler] Fixed uninitialized variable usage

Alexandr Akulich akulichalexander at gmail.com
Sun Sep 25 17:33:06 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129016/
-----------------------------------------------------------

Review request for Telepathy and Aleix Pol Gonzalez.


Repository: ktp-auth-handler


Description
-------

If there is no account (condition at 175 is false), then ```SignOn::Identity *identity``` will be used without initialization at line 210.

Bug reported by the clang static analyzer.

Thanks to Aleix Pol Gonzalez for the idea to run the analyzer. :)


Diffs
-----

  x-telepathy-password-auth-operation.cpp be0ed99 

Diff: https://git.reviewboard.kde.org/r/129016/diff/


Testing
-------

Compiles


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160925/0526a4ff/attachment.html>


More information about the KDE-Telepathy mailing list