Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

[James Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123504/
-----------------------------------------------------------

(Updated Sept. 22, 2016, 6:41 p.m.)


Review request for Telepathy and Martin Klapetek.


Changes
-------

1) Fix terminating players can crash the kded module if TelepathyMPRIS wasn't able to complete rostering the player.
2) Revert use QDBusServiceWatcher's serviceOwnerChanged signal, which in QT 5.7 can no longer watch all ownership change events.
3) Active player selection tweaking.
4) Make Debug more informative and simpler.
5) Comment changes.


Repository: ktp-kded-module


Description
-------

New features:
-Much improved multiple player handling; a number of service availability bugs were fixed.
-Ignore tracks with inadequate metadata
-Separator for empty metadata info fields with (currently) hidden config


Diffs (updated)
-----

  telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
  telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 

Diff: https://git.reviewboard.kde.org/r/123504/diff/


Testing
-------

Compile, run.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160923/f3f02191/attachment.html>