Review Request 128979: [ktp-common-internals] [otr-proxy] Fixed incorrect check of adaptee method existance (ChannelProxyInterfaceOTRAdaptor at this time)

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128979/#review99400
-----------------------------------------------------------


Ship it!




The current implementation was weeeeird. :/ 
`if (!something == -1)`
Wrong at so many levels... O.o

- Aleix Pol Gonzalez


On Sept. 21, 2016, 4:06 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128979/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2016, 4:06 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Fixed incorrect check of adaptee method existance
> 
> See also: https://git.reviewboard.kde.org/r/128844
> 
> I have no idea how I missed this at the first time.
> 
> 
> Diffs
> -----
> 
>   otr-proxy/KTpProxy/svc-channel-proxy.cpp db5d474 
> 
> Diff: https://git.reviewboard.kde.org/r/128979/diff/
> 
> 
> Testing
> -------
> 
> Compiles with less warnings
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160921/33fd8428/attachment.html>