Review Request 128961: [KTp/Declarative/MessagesModel] Fixed allocation of modelIndex variable in onMessageSent()

Aleix Pol Gonzalez aleixpol at kde.org
Tue Sep 20 13:40:24 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128961/#review99331
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Sept. 20, 2016, 3:34 p.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128961/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 3:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> We actually story the index, so we should not just reference it.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/messages-model.cpp 6823574 
> 
> Diff: https://git.reviewboard.kde.org/r/128961/diff/
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160920/81da862c/attachment.html>


More information about the KDE-Telepathy mailing list