Review Request 128960: [KTp/Declarative/MessagesModel] Use message token to prevent message duplication on scrollback received

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128960/
-----------------------------------------------------------

(Updated Sept. 20, 2016, 6:27 p.m.)


Review request for Telepathy.


Changes
-------

Fixed modelIndex variable type.


Repository: ktp-common-internals


Description
-------

Sent and received messages can be received again as scrollback and before this patch it leads to messages duplication.
E.g.: server sent last 20 messages on connection to a group chat, the local user has a network issue and thus got disconnected and connected back with messaging window kept open.

We already have a table for sent messages and this patch:
1) adds insertion of received messages into the same table,
2) uses the table to ignore already sent/received messages.

In future we can also use the table to implement message correction (see XEP-0308, Message_Header_Key "supersedes" and so on).


Diffs (updated)
-----

  KTp/Declarative/messages-model.cpp 6823574 

Diff: https://git.reviewboard.kde.org/r/128960/diff/


Testing
-------

Sent and received messages are not duplicated on scrollback received.


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160920/087648dd/attachment.html>