Review Request 128847: [ktp-common-internals] [debugger] Split logic and UI

[Alexandr Akulich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128847/
-----------------------------------------------------------

(Updated Sept. 6, 2016, 6 p.m.)


Review request for Telepathy.


Changes
-------

Removed m_process member from the debug view class.
Thanks to Anthony Fieroni.


Repository: ktp-common-internals


Description
-------

The main goal of this change is to split logic and UI parts
    
This is the first step in direction to debugger, which:
1) works with any Telepathy process with DebugInterface support;
2) detects new processess "on fly";
3) has no hardcoded services;
4) shows one process just once, independently of number of dbus services, registered by the process.

The change also opens a way to a QML-based UI at some point in future.

Questionable thing is the "TelepathyProcess" class name.
TelepathyService does not fit, because:
1) Single process can expose a number of services (e.g. MissionControl),
2) The debug interface is applicable to any telepathy application, including clients, so word "Service" (which is not associated with clients) would mislead.


Diffs (updated)
-----

  tools/debugger/CMakeLists.txt e35de89 
  tools/debugger/debug-message-view.h ae745db 
  tools/debugger/debug-message-view.cpp ea09d79 
  tools/debugger/main-window.cpp 490f803 
  tools/debugger/telepathy-process.h PRE-CREATION 
  tools/debugger/telepathy-process.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128847/diff/


Testing
-------

Works as previously.


Thanks,

Alexandr Akulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160906/883818bd/attachment.html>