Review Request 128845: [ktp-common-internals] [debugger] Cleanup and reformat

David Edmundson david at davidedmundson.co.uk
Tue Sep 6 12:07:11 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128845/#review98932
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On Sept. 6, 2016, 11:17 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128845/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 11:17 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Removed unneeded includes, destructor moved to be the next after constructor, removed incorrect "virtual" usage, fixed braces and so on.
> 
> This is a preparation to logic and ui split up, which I can not upload until this commit will be landed.
> 
> 
> Diffs
> -----
> 
>   tools/debugger/debug-message-view.h 0bde707 
>   tools/debugger/debug-message-view.cpp af09715 
>   tools/debugger/main-window.h 2e7c968 
> 
> Diff: https://git.reviewboard.kde.org/r/128845/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160906/0c1b5047/attachment.html>


More information about the KDE-Telepathy mailing list