Review Request 128844: [ktp-common-internals] [otr-proxy] Fixed incorrect check of adaptee method existance

Aleix Pol Gonzalez aleixpol at kde.org
Tue Sep 6 11:43:42 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128844/#review98928
-----------------------------------------------------------



We shouldn't have generated code in git...

Pragmatic +1

- Aleix Pol Gonzalez


On Sept. 6, 2016, 11:37 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128844/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 11:37 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> ProxyServiceAdaptor seems to be generated by outdated qt-svc-gen.py from telepathy-qt.
> 
> 
> Diffs
> -----
> 
>   otr-proxy/KTpProxy/svc-proxy-service.cpp 53db454 
> 
> Diff: https://git.reviewboard.kde.org/r/128844/diff/
> 
> 
> Testing
> -------
> 
> Compiles without warnings
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160906/fe180166/attachment.html>


More information about the KDE-Telepathy mailing list