Review Request 128842: Insert chat text edit's history as plain text
Alexandr Akulich
akulichalexander at gmail.com
Tue Sep 6 05:59:19 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128842/#review98913
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Akulich
On Sept. 6, 2016, 2:50 a.m., Mariusz Glebocki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128842/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2016, 2:50 a.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-text-ui
>
>
> Description
> -------
>
> How to reproduce bug:
>
> - type/paste some HTML code in chat text edit, eg. `<span style="background-color: deeppink">test</span>`
> - press down key
> - press up key to insert last history item
>
> result: the text is formatted, HTML markup is lost
> result with the patch: the text is inserted in a form it was before
>
> The patch changes nick completion to plain text too, I guess there is someone with `creat<i>ve n</i>ckname` ;)
>
>
> Diffs
> -----
>
> lib/chat-text-edit.cpp 4d16e20
>
> Diff: https://git.reviewboard.kde.org/r/128842/diff/
>
>
> Testing
> -------
>
> - compile/run: OK
> - use case from the description gives expected result: OK
>
>
> Thanks,
>
> Mariusz Glebocki
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160906/25a7067b/attachment.html>
More information about the KDE-Telepathy
mailing list