Review Request 129069: [Quick Chat] Remove unused popupSide property

Kai Uwe Broulik kde at privat.broulik.de
Wed Oct 19 11:59:36 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129069/
-----------------------------------------------------------

(Updated Oct. 19, 2016, 11:59 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy and Aleix Pol Gonzalez.


Changes
-------

Submitted with commit 0a981e934f37a47fb2ac69c19233a4d24c2c9a3f by Kai Uwe Broulik to branch master.


Repository: ktp-desktop-applets


Description
-------

This property is unused and PlasmaCore.Dialog location and visualParent already take care of this.


Diffs
-----

  chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml a089fbc 
  chat/org.kde.ktp-chat/contents/ui/FullChatList.qml 258c1cf 

Diff: https://git.reviewboard.kde.org/r/129069/diff/


Testing
-------

Popup location still sensible in all four panel locations


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20161019/0a2bcde0/attachment.html>


More information about the KDE-Telepathy mailing list