Review Request 126510: ktp-kded-module KActivities for status handler multiple account presence

James Smith smithjd15 at gmail.com
Tue Nov 22 05:29:36 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126510/
-----------------------------------------------------------

(Updated Nov. 21, 2016, 10:29 p.m.)


Review request for Telepathy.


Changes
-------

1) New-style signals and slots.
2) Tidier signal / slot function inlining.
3) Trigger a presence update when the activity service state changes.
4) Clarify activity service not running debug warning; disable for unknown service state.
5) Remove setDiskPresence() debug warning.


Bugs: 284517
    http://bugs.kde.org/show_bug.cgi?id=284517


Repository: ktp-kded-module


Description
-------

New features:
-Saves per-activity account presences between activities.


Diffs (updated)
-----

  CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
  account-status-helper.h PRE-CREATION 
  account-status-helper.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126510/diff/


Testing (updated)
-------

Compile, run.

Disabling restore last presence on login doesn't work because of a spurious signal in KActivities <= 5.27.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20161122/27b7c3d2/attachment.html>


More information about the KDE-Telepathy mailing list