Review Request 124875: ktp-desktop-applets tray applet StatusHandlerController and propagating PresenceModel integration

[Martin Klapetek]

> On Feb. 29, 2016, 8:48 p.m., Martin Klapetek wrote:
> > contactlist/org.kde.ktp-contactlist/contents/ui/main.qml, lines 118-120
> > <https://git.reviewboard.kde.org/r/124875/diff/2/?file=445979#file445979line118>
> >
> >     The opposite of "Enable" is "Disable". Alternatively, the opposite of "Deactivate" is "Activate".
> 
> James Smith wrote:
>     The Deactivate option onlyshows if the mpris plugin is active.

That's not the point, you're using wrong English.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124875/#review92930
-----------------------------------------------------------


On March 7, 2016, 8:11 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124875/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 8:11 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> New features:
> -Enable or disable the now playing plugin.
> -Propagating presence model for updating the custom presences.
> 
> 
> Diffs
> -----
> 
>   contactlist/org.kde.ktp-contactlist/contents/ui/main.qml 43b8c8ebeef8c018450719fba3ac06e42434e326 
> 
> Diff: https://git.reviewboard.kde.org/r/124875/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160307/6e6b6b87/attachment-0001.html>