Review Request 126901: ktp-contact-runner multiple account presence

[James Smith]

> On March 3, 2016, 10:53 p.m., David Edmundson wrote:
> > src/contactrunner.cpp, line 548
> > <https://git.reviewboard.kde.org/r/126901/diff/1/?file=444623#file444623line548>
> >
> >     I think this might be calling for a function.

It's repetitive code but I don't think much can be done about it.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126901/#review93146
-----------------------------------------------------------


On Feb. 22, 2016, 9:27 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126901/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2016, 9:27 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-runner
> 
> 
> Description
> -------
> 
> New features:
> -New runner matches from PresenceModel.
> -New runner matches for individual accounts.
> -Use of init().
> 
> 
> Diffs
> -----
> 
>   src/contactrunner.h 19e94fec67586c0231adae837718d40d09e984d2 
>   src/contactrunner.cpp 26057920fbbe303ec294e43e877b526fff9d2c76 
> 
> Diff: https://git.reviewboard.kde.org/r/126901/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160307/a9033fe9/attachment.html>