Review Request 123504: ktp-kded-module Now Playing multiple players for status handler multiple account presence

James Smith smithjd15 at gmail.com
Mon Mar 7 06:52:44 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123504/
-----------------------------------------------------------

(Updated March 7, 2016, 6:52 a.m.)


Review request for Telepathy.


Changes
-------

The serviceWatcher signal should be disconnected automatically.


Repository: ktp-kded-module


Description
-------

New features:
-Much improved multiple player handling; a number of service availability bugs were fixed.
-Default template changed from 'Now Listening to ...'  to 'Now Playing ...'
-Ignore tracks with inadequate metadata
-Separator for empty metadata info fields with (currently) hidden config


Diffs (updated)
-----

  config/telepathy-kded-config.cpp 4ed6a16cc8f489794a08a3c031d7a8ec7b010b2d 
  telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
  telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 

Diff: https://git.reviewboard.kde.org/r/123504/diff/


Testing
-------

Compile, run.


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160307/891a2d2b/attachment.html>


More information about the KDE-Telepathy mailing list