Review Request 123485: ktp-kded-module status handler multiple account presence

[James Smith]

> On March 3, 2016, 10:40 p.m., David Edmundson wrote:
> > account-status-helper.cpp, line 86
> > <https://git.reviewboard.kde.org/r/123485/diff/1/?file=444990#file444990line86>
> >
> >     why are we changing presence in the destructor?
> >     
> >     that means on logout we'll *start* connecting

This un-sets any automatic presence when the kded module unloads. I haven't had this cause MC to go online on logout. Doesn't MC terminate when it's last consumer goes away, anyway?


> On March 3, 2016, 10:40 p.m., David Edmundson wrote:
> > status-handler.cpp, line 226
> > <https://git.reviewboard.kde.org/r/123485/diff/1/?file=445004#file445004line226>
> >
> >     in /theory/ MC does this internally

There are a number of bug reports surrounding this, and it's much better to have the kded at least aware of the current online state, so a presence change doesn't inadvertently put an account online. Having this in the kded module plugin improves reliability, especially because of automatic presences,  over the mission control approach, IMO.


> On March 3, 2016, 10:40 p.m., David Edmundson wrote:
> > account-status-helper.cpp, line 63
> > <https://git.reviewboard.kde.org/r/123485/diff/1/?file=444990#file444990line63>
> >
> >     we don't really need signal mappers anymore now we have lambdas in Qt5 
> >     Worth looking into them, but it's here now.

They really simplify the code, thanks.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123485/#review93144
-----------------------------------------------------------


On March 7, 2016, 6:50 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123485/
> -----------------------------------------------------------
> 
> (Updated March 7, 2016, 6:50 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 293443, 334542, 337881, 340201, and 340781
>     http://bugs.kde.org/show_bug.cgi?id=293443
>     http://bugs.kde.org/show_bug.cgi?id=334542
>     http://bugs.kde.org/show_bug.cgi?id=337881
>     http://bugs.kde.org/show_bug.cgi?id=340201
>     http://bugs.kde.org/show_bug.cgi?id=340781
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> New classes:
> -AccountStatusHelper, a multiple-account-presence QDBusAbstractInterface replacement for AutoConnect.
> -PluginQueue, a QDBusAbstractInterface for presence and status message plugins.
> -Presence / Status Message Inserter classes, for queuing presences and status messages.
> 
> New properties:
> -TelepathyKDEDModulePlugin: KTp::PluginQueue pluginState().
> 
> New methods:
> -TelepathyKDEDModulePlugin: virtual pluginInit(bool), method setPluginState(KTp::PluginQueue), method configureEnabled(bool).
> 
> New features:
> -Newly enabled and online account presence changes to offline or account requested presence depending on network connection state and autoconnect property. 
> -Offline global presence will override per-account presences temporarily.
> -PluginQueue globs presence change events.
> -StatusHandler dynamically disables and enables plugin queues if there are online accounts.
> -StatusHandler and TelepathyKDEDModulePlugin no longer require GlobalPresence.
> 
> Various other cleanups, documentation, and improvements.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 
>   account-status-helper.h PRE-CREATION 
>   account-status-helper.cpp PRE-CREATION 
>   autoaway.h 5e2a56100b56e6d21bc649f9032c8bece9031452 
>   autoaway.cpp 4881c71afab2be2468c3c883523d2844865e6247 
>   autoconnect.h 0f3ab137cf67cce9c7467144a45d1706ec9cc007 
>   autoconnect.cpp 99512b265e0e6ae34f83263ffa6337741db652ea 
>   config/telepathy-kded-config.cpp 4ed6a16cc8f489794a08a3c031d7a8ec7b010b2d 
>   config/telepathy-kded-config.ui 2b80dfa34381af2e9206384a31c025f9b914854a 
>   org.kde.Telepathy.AccountStatusHelper.xml PRE-CREATION 
>   org.kde.Telepathy.PluginQueue.xml PRE-CREATION 
>   screensaveraway.h 92344e891ccde16d53771c3e279d845f4d800b2d 
>   screensaveraway.cpp f226564a5bf7b396965b5ae21f81d93b7edc3ef8 
>   status-handler-plugin-queue.h PRE-CREATION 
>   status-handler-plugin-queue.cpp PRE-CREATION 
>   status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff 
>   status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc 
>   telepathy-kded-module-plugin.h 4c161696a706e82059a7eb314773c3644fe26bd7 
>   telepathy-kded-module-plugin.cpp daf73c66947bc946097de7a8e8a1518555131145 
>   telepathy-module.h 17ef4cef27b90cbced6c66846ed82cb5c36fb532 
>   telepathy-module.cpp b74053bc1817d773a4fe37769e42f4013ced5425 
>   telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
>   telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 
>   telepathy-status-inserter.h PRE-CREATION 
>   telepathy-status-inserter.cpp PRE-CREATION 
>   tests/CMakeLists.txt 7ec77495417a6790060ea5ea7126c46399dff755 
> 
> Diff: https://git.reviewboard.kde.org/r/123485/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160307/eefee611/attachment-0001.html>