Review Request 128137: [Quick Chat] Handle when ConversationsModel activeChatIndex changes

[Kai Uwe Broulik]

> On Juni 9, 2016, 2:05 nachm., Aleix Pol Gonzalez wrote:
> > Right, I misread the description, I guess it's correct then.

I verified that when someone sends me a message in a conversation the popup doesn't open to not interrupt if the conversation is already there.

Only if it's a new conversation, it opens right away but that has been the case previously and also happens with regular ktp-text-ui


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128137/#review96320
-----------------------------------------------------------


On Juni 9, 2016, 12:33 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128137/
> -----------------------------------------------------------
> 
> (Updated Juni 9, 2016, 12:33 nachm.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> When a conversation with a new contact is opened, the chat expands automatically. However, if a conversation is already open, and you select the contact in the contact list, nothing happens. This patch fixes this.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/FullChatList.qml bd28eaf 
> 
> Diff: https://git.reviewboard.kde.org/r/128137/diff/
> 
> 
> Testing
> -------
> 
> Start plasmashell, then:
> * Chose a contact from my chat list plasmoid -> got a popup
> * Chose the same contact again -> previously nothing would happen, now I get a poup again
> * Had the contact write something to me -> popup did not open but got an "unread" badge as it should be
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160609/5aa9ecd8/attachment.html>