Review Request 128135: [Quick Chat] Set time label height to paintedHeight

David Edmundson david at davidedmundson.co.uk
Thu Jun 9 10:53:29 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128135/#review96311
-----------------------------------------------------------


Ship it!




FYI: height by default is the paintedHeight.

This is working round an incredibly terrible wrong redeclaration of height property in PlasmaComponents.Label.

- David Edmundson


On June 9, 2016, 10:38 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128135/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 10:38 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-desktop-applets
> 
> 
> Description
> -------
> 
> This fixes the base of the chat message and time not lining up as well as the time sometimes bleeding outside the delegate in case of a one-line message.
> 
> 
> Diffs
> -----
> 
>   chat/org.kde.ktp-chat/contents/ui/TextDelegate.qml ab686a6 
> 
> Diff: https://git.reviewboard.kde.org/r/128135/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160609/a3192392/attachment.html>


More information about the KDE-Telepathy mailing list