Review Request 128524: qmlRegisterType Tp::PendingOperation

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jul 26 08:55:28 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128524/#review97848
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On July 26, 2016, 10:47 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128524/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 10:47 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Although we don't actually care about the return value of startFileTransfer in the Quick Chat applet, QML fails to call this method if the aforementioned type isn't registered.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/qml-plugins.cpp 4956a1c 
> 
> Diff: https://git.reviewboard.kde.org/r/128524/diff/
> 
> 
> Testing
> -------
> 
> telepathyManager.startFileTransfer now works
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160726/7249a004/attachment.html>


More information about the KDE-Telepathy mailing list