Review Request 128460: ktp-text-ui: Added a filter for geo uri support

[Alexandr Akulich]

> On July 15, 2016, 3:57 p.m., Aleix Pol Gonzalez wrote:
> > filters/geopoint/geopoint-filter.cpp, line 34
> > <https://git.reviewboard.kde.org/r/128460/diff/1/?file=471790#file471790line34>
> >
> >     Can we maybe use something that is more free software friendly than Google Maps?
> 
> Alexandr Akulich wrote:
>     As I said, I tried OSM first, but not managed to make it to works in a hour, so I switched to Google Maps for the "prove of concept" at least.
>     
>     I would try again to make it works with OSM after 5 August.
> 
> Sandro Knauß wrote:
>     not that difficult:
>     http://www.openstreetmap.org/?mlat=50.8295&mlon=12.9204#map=16/50.8295/12.9204
>     
>     mlot/mlat are the positions of the marker and 16 is the zoom level
> 
> Alexandr Akulich wrote:
>     Big thank you! This is what I need!
>     I'll change it right now then (without configuration support).

It doesn't work in iframe. I had to replace it with

https://wiki.openstreetmap.org/wiki/OpenLinkMap#Embed_map_in_another_website


- Alexandr


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128460/#review97439
-----------------------------------------------------------


On July 16, 2016, 6:58 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128460/
> -----------------------------------------------------------
> 
> (Updated July 16, 2016, 6:58 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Added a geopoint filter which adds an iframe with a map for each geo:<double,double> in message (RFC 5870).
> 
> I tried to use openstreetmap, but had no success. I would like to add an option to select osm or google maps, but I have no time to do it now.
> 
> 
> Diffs
> -----
> 
>   filters/CMakeLists.txt 8118b13 
>   filters/geopoint/CMakeLists.txt PRE-CREATION 
>   filters/geopoint/geopoint-filter.h PRE-CREATION 
>   filters/geopoint/geopoint-filter.cpp PRE-CREATION 
>   filters/geopoint/ktptextui_message_filter_geopoint.desktop.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128460/diff/
> 
> 
> Testing
> -------
> 
> It works for me.
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160716/febe8099/attachment.html>