Review Request 126834: ktp-common-internals propagating presence model for status handler integration and global / multiple account presence fixes

Martin Klapetek martin.klapetek at gmail.com
Mon Feb 29 19:56:30 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126834/#review92932
-----------------------------------------------------------



Can you please be more specific with your descriptions? I have no clue what's the point of this change or what is it supposed to do/fix/prevent.

- Martin Klapetek


On Feb. 23, 2016, 8:16 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126834/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 8:16 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> New features:
> -Simplified API, sends and collects changes over DBus.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/presence-model.h 8f206b880f48640626322269a14956f105482f69 
>   KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519 
> 
> Diff: https://git.reviewboard.kde.org/r/126834/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160229/c45f3fa3/attachment-0001.html>


More information about the KDE-Telepathy mailing list