Review Request 127005: Port to QWebEngine

[Niels Ole Salscheider]

> On Feb. 8, 2016, 3:14 p.m., Martin Klapetek wrote:
> > Thanks for working on this
> > 
> > Do you know what's the status of webengine packaging in distros? Last time I remember they were much unhappy about it. If they cannot package that, we won't be able to use this.
> > 
> > That said, do the filter plugins work too?

I think the situation got much better with Qt 5.6 since many libraries were unbundled. We did not have many problems packaging it for Exherbo but it seems to be a bit more complicated for the BSDs.
I thought that there were other applications in KDE using it (at least in some feature branches), but I might be wrong. We should definitely find out about that.

You mean things like emoticons, the image preview, and so on? These seem to work.


> On Feb. 8, 2016, 3:14 p.m., Martin Klapetek wrote:
> > lib/adium-theme-view.h, line 173
> > <https://git.reviewboard.kde.org/r/127005/diff/1/?file=443601#file443601line173>
> >
> >     This worked based on a config file option. I imagine we can replace this with qputenv("QTWEBENGINE_REMOTE_DEBUGGING"...) instead? Ie. keep the config option working.

Yes, QTWEBENGINE_REMOTE_DEBUGGING is the new way for the inspector in QWebEngine.
Using qputenv would be possible, but you have to set QTWEBENGINE_REMOTE_DEBUGGING to a port number and then point you web browser to that port. I think it would be easier to just set that env var manually when you want the inspector.


> On Feb. 8, 2016, 3:14 p.m., Martin Klapetek wrote:
> > lib/adium-theme-view.cpp, line 112
> > <https://git.reviewboard.kde.org/r/127005/diff/1/?file=443602#file443602line112>
> >
> >     This seems to be lost?

Unfortunately, this seems not to be available in QWebEngine at the moment...


> On Feb. 8, 2016, 3:14 p.m., Martin Klapetek wrote:
> > lib/adium-theme-view.cpp, line 315
> > <https://git.reviewboard.kde.org/r/127005/diff/1/?file=443602#file443602line315>
> >
> >     Why this whole thing is being removed?

JavaScript proxies are not available in QWebEngine. Instead, you are supposed to use QWebChannel to communicate with the C++ side.

But the only purpose of this is to emit the viewReady signal when the page is loaded. We can instead just emit it when the QWebEngineView emits loadFinished.

AFAICT this is only used for the style preview and that works also with the new code.


- Niels Ole


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127005/#review92169
-----------------------------------------------------------


On Feb. 7, 2016, 8:21 p.m., Niels Ole Salscheider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127005/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2016, 8:21 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> This ports the message viewer from QWebKit to QWebEngine.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 91cd304 
>   adiumxtra-protocol-handler/CMakeLists.txt f78a62f 
>   app/CMakeLists.txt 9a90cec 
>   config/appearance/CMakeLists.txt dfb5d04 
>   config/appearance/appearance-config-tab.cpp f2f298b 
>   lib/CMakeLists.txt 5294521 
>   lib/adium-theme-view.h 5a0c2e6 
>   lib/adium-theme-view.cpp 26e6d50 
>   lib/chat-search-bar.h c8c5118 
>   lib/chat-search-bar.cpp 484975a 
>   lib/chat-widget.h 588407c 
>   lib/chat-widget.cpp 7975057 
>   logviewer/CMakeLists.txt c36157c 
>   logviewer/log-viewer.cpp 1ae0f7b 
>   logviewer/message-view.h ec592c7 
>   logviewer/message-view.cpp eafc53e 
> 
> Diff: https://git.reviewboard.kde.org/r/127005/diff/
> 
> 
> Testing
> -------
> 
> - Builds
> - Chats with the text UI work
> - Links work
> - The log viewer works
> 
> 
> Thanks,
> 
> Niels Ole Salscheider
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160208/6b78dbe2/attachment-0001.html>