Review Request 127007: logviewer: Fix signals of search field

Aleix Pol Gonzalez aleixpol at kde.org
Mon Feb 8 00:26:23 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127007/#review92136
-----------------------------------------------------------




logviewer/log-viewer.cpp (line 118)
<https://git.reviewboard.kde.org/r/127007/#comment62853>

    const& doesn't belong within SLOT() and SIGNAL()


- Aleix Pol Gonzalez


On Feb. 7, 2016, 9:26 p.m., Niels Ole Salscheider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127007/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2016, 9:26 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> This fixes the search in the log viewer.
> 
> 
> Diffs
> -----
> 
>   logviewer/log-viewer.h e6b6d3dbab67ceb3286bd402121e1b0504e8a0af 
>   logviewer/log-viewer.cpp 1ae0f7b87b0d8fee0587215fec38fac2af047b9d 
> 
> Diff: https://git.reviewboard.kde.org/r/127007/diff/
> 
> 
> Testing
> -------
> 
> - Builds
> - Searching works again
> 
> 
> Thanks,
> 
> Niels Ole Salscheider
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20160208/d275098f/attachment.html>


More information about the KDE-Telepathy mailing list